Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make system context menu code more understandable #155747

Merged
merged 3 commits into from
Jul 21, 2022
Merged

make system context menu code more understandable #155747

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c523883
removing unnecessary enablements
sbatten Jul 20, 2022
5b9218b
add some comments
sbatten Jul 20, 2022
15f79a7
address feedback, bring back enablements
sbatten Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/vs/platform/windows/electron-main/window.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,15 +292,20 @@ export class CodeWindow extends Disposable implements ICodeWindow {

// Windows Custom System Context Menu
// See https://github.com/electron/electron/issues/24893
//
// The purpose of this is to allow for the context menu in the Windows Title Bar
//
// Currently, all mouse events in the title bar are captured by the OS
// thus we need to capture them here with a window hook specific to Windows
// and then forward them to the correct window.
if (isWindows && useCustomTitleStyle) {
// https://docs.microsoft.com/en-us/windows/win32/menurc/wm-initmenu
const WM_INITMENU = 0x0116;
// This sets up a listener for the window hook. This is a Windows-only API provided by electron.
this._win.hookWindowMessage(WM_INITMENU, () => {
const [x, y] = this._win.getPosition();
const cursorPos = screen.getCursorScreenPoint();

this._win.setEnabled(false);
this._win.setEnabled(true);

this._onDidTriggerSystemContextMenu.fire({ x: cursorPos.x - x, y: cursorPos.y - y });
return 0; // skip native menu
});
Expand Down