Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use code editor service over dynamic editor registration #154352

Merged
merged 3 commits into from
Jul 8, 2022
Merged

Conversation

jrieken
Copy link
Member

@jrieken jrieken commented Jul 7, 2022

This fixes #153110

…rties can influence opening, e.g diff or merge editor

This allows to remove editor registration for 3wm editor.
@jrieken jrieken self-assigned this Jul 7, 2022
@vscodenpa vscodenpa added this to the July 2022 milestone Jul 7, 2022
alexr00
alexr00 previously approved these changes Jul 7, 2022
@jrieken
Copy link
Member Author

jrieken commented Jul 7, 2022

@alexr00 sorry, re-requesting for the last commit which fixes a compile issue

@bpasero bpasero self-requested a review July 7, 2022 13:33
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 👍

@jrieken jrieken merged commit 31a22e7 into main Jul 8, 2022
@jrieken jrieken deleted the joh/issue153110 branch July 8, 2022 06:58
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have a good way to redirect open request into the merge editor
4 participants