Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check lang id while filtering #145756

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Check lang id while filtering #145756

merged 1 commit into from
Mar 23, 2022

Conversation

rzhao271
Copy link
Contributor

We still grab the first language ID we see, but if it's invalid, we don't allow any settings to be shown.

This PR fixes #145709

@rzhao271 rzhao271 self-assigned this Mar 22, 2022
@rzhao271 rzhao271 added this to the March 2022 milestone Mar 22, 2022
@rzhao271 rzhao271 requested a review from isidorn March 22, 2022 17:43
@rzhao271 rzhao271 merged commit 12f99e0 into main Mar 23, 2022
@rzhao271 rzhao271 deleted the rzhao271/lang-filter-id-check branch March 23, 2022 15:20
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language filter does not do exact match
2 participants