Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode-ext-api] expose remote authority #130090

Merged
merged 1 commit into from
Sep 10, 2021
Merged

[vscode-ext-api] expose remote authority #130090

merged 1 commit into from
Sep 10, 2021

Conversation

akosyakov
Copy link
Contributor

fix #111371: expose remote authority

@hediet hediet requested review from bpasero and removed request for bpasero August 4, 2021 14:09
@bpasero bpasero assigned aeschli, jrieken and alexdima and unassigned bpasero and aeschli Aug 4, 2021
@chrmarti
Copy link
Contributor

chrmarti commented Sep 8, 2021

@alexdima @jrieken This would help solve an issue in Remote-Containers. Can we merge this as proposed API?

alexdima
alexdima approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But the current proposed change adds this as stable API, not as proposed API @chrmarti

@chrmarti chrmarti self-assigned this Sep 10, 2021
@chrmarti
Copy link
Contributor

Will move it to proposed. Thanks @akosyakov !

@chrmarti chrmarti merged commit 84ea7af into microsoft:main Sep 10, 2021
@akosyakov akosyakov deleted the akosyakov/way-to-discover-remote-111371 branch September 10, 2021 08:05
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexdima alexdima alexdima approved these changes

Assignees

@jrieken jrieken

@alexdima alexdima

@chrmarti chrmarti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Way to discover remote authority in empty window
6 participants
@akosyakov @chrmarti @alexdima @bpasero @jrieken @aeschli