Make list focus icon themeable #126288
Merged
Make list focus icon themeable #126288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomoreno
approved these changes
Jun 15, 2021
jrieken
approved these changes
Jun 15, 2021
|
There needs to be a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #125998 and makes the focused icon themeable by introducing
list.activeSelectionIconForeground. In the last release we inherited the focus foreground for all focus states, but this caused issues in themes that didn't have a high contrasting focus state and was especially obvious in the suggest widget. Now this allows for themes to opt-in to the new styling instead of turning this on by default (I've added these to our default dark/light themes)Before
After