Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🆙 vscode-sqlite3@5.x #106399

Closed
wants to merge 7 commits into from
Closed

🆙 vscode-sqlite3@5.x #106399

wants to merge 7 commits into from

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Sep 10, 2020

This updates vscode-node-sqlite3 to the 5.x releases with NAPI support.

Blocked by: microsoft/vscode-node-sqlite3#8

@bpasero bpasero self-assigned this Sep 10, 2020
@bpasero bpasero added this to the September 2020 milestone Sep 10, 2020
@bpasero bpasero modified the milestones: September 2020, On Deck Sep 11, 2020
@bpasero bpasero marked this pull request as draft October 2, 2020 08:08
@bpasero bpasero modified the milestones: On Deck, Backlog, November 2020 Oct 2, 2020
@bpasero bpasero modified the milestones: November 2020, On Deck Oct 13, 2020
@bpasero bpasero removed this from the On Deck milestone Jan 4, 2021
@joaomoreno joaomoreno changed the base branch from master to main February 15, 2021 08:51
@bpasero
Copy link
Member Author

bpasero commented Apr 6, 2021

@deepak1556 this latest run seems to result in native crash on shutdown:

FATAL ERROR: Error::ThrowAsJavaScriptException napi_throw
 1: 00007FF71604AFE6 node::Buffer::New+47254
 2: 00007FF71604B1E5 node::Buffer::New+47765
 3: 00007FF71604B019 node::Buffer::New+47305
 4: 00007FF716BEAEF5 napi_fatal_error+149
 5: 00007FFDA59D1D87 Napi::Error::Fatal+23 [d:\a\1\s\node_modules\node-addon-api\napi-inl.h]:L2172
 6: 00007FFDA59D1E8F Napi::Error::ThrowAsJavaScriptException+255 [d:\a\1\s\node_modules\node-addon-api\napi-inl.h]:L2246
 7: 00007FFDA59EA914 node_sqlite3::Statement::Finalize_+340 [d:\a\1\s\node_modules\vscode-sqlite3\src\statement.cc]:L890
 8: 00007FFDA59E5536 node_sqlite3::Statement::Process+198 [d:\a\1\s\node_modules\vscode-sqlite3\src\statement.cc]:L48
 9: 00007FFDA59E7AA1 node_sqlite3::Statement::Work_AfterRun+1025 [d:\a\1\s\node_modules\vscode-sqlite3\src\statement.cc]:L525
10: 00007FF716BECD6A napi_ref_threadsafe_function+1338
11: 00007FF716C08118 uv_signal_start_oneshot+1144
12: 00007FF71606B7B9 uv_run+313
13: 00007FF716033261 node::EmitAsyncDestroy+190689
14: 00007FF716033596 node::EmitAsyncDestroy+191510
15: 00007FF71600281D node::FreeEnvironment+13
16: 00007FF713500875 std::__1::__vector_base<v8::CpuProfileDeoptFrame,std::__1::allocator<v8::CpuProfileDeoptFrame> >::__end_cap+68453
17: 00007FF71415E13D v8::Location::GetColumnNumber+1708781
18: 00007FF71415FC0C v8::Location::GetColumnNumber+1715644
19: 00007FF71415B3D0 v8::Location::GetColumnNumber+1697152
20: 00007FF714041179 v8::Location::GetColumnNumber+541481
21: 00007FF714040D8C v8::Location::GetColumnNumber+540476
22: 00007FF71403FCC4 v8::Location::GetColumnNumber+536180
23: 00007FF71403FFED v8::Location::GetColumnNumber+536989
24: 00007FF713431506 Ordinal0+5382
25: 00007FF7191DFC42 uv_random+18070994
26: 00007FFDB6B784D4 BaseThreadInitThunk+20
27: 00007FFDB8571821 RtlUserThreadStart+33

In https://dev.azure.com/monacotools/Monaco/_build/results?buildId=111528&view=logs&j=672276a2-8d3a-5fab-615d-090c51352f92&t=354d3e13-3534-5793-0b68-b00f8c1d36f3&l=526

@deepak1556
Copy link
Collaborator

@bpasero please see #120034 (comment) for context on the crash.

@deepak1556
Copy link
Collaborator

This can be unblocked once nodejs/node-addon-api#902 gets released.

@bpasero bpasero closed this Sep 18, 2021
@bpasero bpasero deleted the ben/sqlite-5.x branch September 24, 2021 18:50
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants