Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+C does not stop node server in external Command Line #25195

Closed
raelb opened this issue Apr 22, 2017 · 8 comments · Fixed by #29352
Closed

Ctrl+C does not stop node server in external Command Line #25195

raelb opened this issue Apr 22, 2017 · 8 comments · Fixed by #29352
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded windows VS Code on Windows issues
Milestone

Comments

@raelb
Copy link

raelb commented Apr 22, 2017

From a normal Windows command prompt, ctrl+c will stop a node server running.

However, if I start the command prompt via the VS Code menu item Open in Command Prompt, then pressing ctrl+c (even multiple times) does not stop the server as usual.

Running on Windows 10 x64
VS Code 1.11.2

Also asked on SO:
http://stackoverflow.com/questions/43531894/ctrlc-does-not-stop-node-server-in-command-line-from-vs-code

@Tyriar Tyriar closed this as completed Apr 24, 2017
@Tyriar Tyriar reopened this Apr 24, 2017
@Tyriar Tyriar added this to the Backlog milestone Apr 24, 2017
@Tyriar Tyriar added info-needed Issue requires more information from poster windows VS Code on Windows issues labels Apr 24, 2017
@Tyriar
Copy link
Member

Tyriar commented Apr 24, 2017

@raelb does this still happen when you add this to your settings?

"terminal.external.windowsExec": "C:\\Windows\\sysnative\\cmd.exe"

@raelb
Copy link
Author

raelb commented Apr 25, 2017

If I add that setting it works fine.

Note after I install VS Code it already has similar setting:

// Place your settings in this file to overwrite the default settings
{
"window.zoomLevel": 0.5,
"terminal.integrated.shell.windows": "C:\WINDOWS\Sysnative\cmd.exe",
"terminal.external.windowsExec": "C:\Windows\sysnative\cmd.exe"
}

@Tyriar Tyriar modified the milestones: May 2017, Backlog Apr 25, 2017
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Apr 25, 2017
@Tyriar
Copy link
Member

Tyriar commented Apr 25, 2017

We should just hardcode 32/64-bit cmd.exe then if that works, right now we point to the COMSPEC environment variable that defaults to the 32-bit version of cmd.exe regardless of what version of Windows you're on.

@oliverjanik
Copy link

oliverjanik commented Jun 15, 2017

I can reproduce. This has been a bug for the longest time. Also this true not just for node processes. E.g. when I launch a go web service that I'm developing.

@Tyriar Tyriar changed the title Ctrl+C does not stop node server in Command Line Ctrl+C does not stop node server in external Command Line Jun 16, 2017
@Tyriar
Copy link
Member

Tyriar commented Jun 23, 2017

I merged #29352 which should select the sysnative version. I noticed two things though, firstly I couldn't reproduce the issue on my machine (Windows 10 64-bit), plus I didn't see it change to Sysnative using the same trick we used to fix a similar issue with 64-bit PowerShell. This may be blocked by shipping a 64-bit version of VS Code.

I'm interested to hear if the problem is fixed in Insiders on Monday.

@oliverjanik
Copy link

I'll test when this gets released.

@michelkaporin
Copy link
Contributor

Works for me, adding verified.

@michelkaporin michelkaporin added the verified Verification succeeded label Jun 29, 2017
@Gonkers
Copy link

Gonkers commented Sep 18, 2017

Edit: found an open issue more appropriate.... #9347

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants