Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot parse treesitter telemetry #224310

Closed
lramos15 opened this issue Jul 30, 2024 · 2 comments · Fixed by #224387
Closed

Cannot parse treesitter telemetry #224310

lramos15 opened this issue Jul 30, 2024 · 2 comments · Fixed by #224387
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders telemetry Telemetry system issues verified Verification succeeded
Milestone

Comments

@lramos15
Copy link
Member

private sendParseTimeTelemetry(eventName: string, languageId: string, time: number, passes: number): void {
this._logService.debug(`Tree parsing (${eventName}) took ${time} ms and ${passes} passes.`);
type ParseTimeClassification = {
owner: 'alros';
comment: 'Used to understand how long it takes to parse a tree-sitter tree';
languageId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The programming language ID.' };
time: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The ms it took to parse' };
passes: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The number of passes it took to parse' };
};
this._telemetryService.publicLog2<{ languageId: string; time: number; passes: number }, ParseTimeClassification>(`treeSitter.${eventName}`, { languageId, time, passes });
}
}

We don't have support for string interpolation like this as the static analyzer cannot understand what ${eventName} will be.

@lramos15 lramos15 added bug Issue identified by VS Code Team member as probable bug telemetry Telemetry system issues labels Jul 30, 2024
@alexr00 alexr00 added this to the August 2024 milestone Jul 31, 2024
alexr00 added a commit that referenced this issue Jul 31, 2024
alexr00 added a commit that referenced this issue Jul 31, 2024
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 31, 2024
Copy link

Issue marked as unreleased but unable to locate closing commit in repo history. If this was closed in a separate repo you can add the insiders-released label directly, or comment \closedWith someShaThatWillbeReleasedWhenThisIsRelesed.

@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jul 31, 2024
@vs-code-engineering vs-code-engineering bot removed the unreleased Patch has not yet been released in VS Code Insiders label Jul 31, 2024
Copy link

		Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting `\closedWith someCommitSha`, or directly add the `insiders-released` label if you know this has already been releaased

@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 31, 2024
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 24, 2024
@lramos15 lramos15 added the verified Verification succeeded label Aug 28, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders telemetry Telemetry system issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants