Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommentController.activeCommentThread not updated when navigating from editor gutter #223824

Closed
chrmarti opened this issue Jul 26, 2024 · 0 comments · Fixed by #223839
Closed

CommentController.activeCommentThread not updated when navigating from editor gutter #223824

chrmarti opened this issue Jul 26, 2024 · 0 comments · Fixed by #223839
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
July 2024

Comments

@chrmarti
Copy link
Contributor

#223021

Clicking the icon:
Image
does not update CommentController.activeCommentThread.
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release labels Jul 26, 2024
@alexr00 alexr00 added this to the July 2024 milestone Jul 26, 2024
alexr00 added a commit that referenced this issue Jul 26, 2024
@alexr00
CommentController.activeCommentThread not updated when navigating fro…
6909d5d 
…m editor gutter

Fixes #223824
@alexr00 alexr00 mentioned this issue Jul 26, 2024
Merged
alexr00 added a commit that referenced this issue Jul 26, 2024
@alexr00
CommentController.activeCommentThread not updated when navigating fro…
06800b8 
…m editor gutter

Fixes #223824
@alexr00 alexr00 mentioned this issue Jul 26, 2024
Merged
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jul 26, 2024
alexr00 added a commit that referenced this issue Jul 26, 2024
@alexr00
CommentController.activeCommentThread not updated when navigating fro…
64e4666 
…m editor gutter (#223840)

Fixes #223824
@alexr00 alexr00 added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 26, 2024
@chrmarti chrmarti added the verified Verification succeeded label Jul 26, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
July 2024
3 participants
@chrmarti @alexr00 @vscodenpa