Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't horizontal scroll to the end of logpoint's and conditional breakpoint's placeholder #221506

Closed
yamgomes opened this issue Jul 11, 2024 · 4 comments · Fixed by #224356
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@yamgomes
Copy link

yamgomes commented Jul 11, 2024

Type: Bug

  1. Have a narrow-ish VS Code window (so that the tooltip doesn't fit)
  2. Click to add a logpoint or conditional breakpoint
  3. Try horizontal scrolling (Shift + Scroll) to see the end of the message

Expected: See the entire placeholder message
Actual: The placeholder message cuts off after "'Escape' to c..."

VS Code version: Code 1.91.1 (f1e16e1, 2024-07-09T22:06:49.809Z)
OS version: Windows_NT x64 10.0.22631
Modes:
Remote OS version: Linux x64 5.15.153.1-microsoft-standard-WSL2

System Info
Item Value
CPUs AMD Ryzen 5 5600 6-Core Processor (12 x 3500)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) undefined
Memory (System) 31.93GB (7.00GB free)
Process Argv
Screen Reader no
VM 0%
Item Value
Remote WSL: Ubuntu
OS Linux x64 5.15.153.1-microsoft-standard-WSL2
CPUs AMD Ryzen 5 5600 6-Core Processor (12 x 0)
Memory (System) 23.47GB (15.66GB free)
VM 0%
Extensions: none
@yamgomes yamgomes changed the title Can't scroll to the end of logpoint's and conditional breakpoint's placeholder Can't horizontal scroll to the end of logpoint's and conditional breakpoint's placeholder Jul 11, 2024
@yamgomes
Copy link
Author

This is the farthest the scrolling goes, no matter the width of the window. Maybe the scrollable width is not taking the offset from the dropdown into account?

image

image

@roblourens
Copy link
Member

I wasn't expecting this to scroll since we hide the scrollbar. It surprises me that it does... I think we should just show the placeholder in a tooltip.

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Jul 30, 2024
@roblourens roblourens added this to the August 2024 milestone Jul 31, 2024
roblourens added a commit that referenced this issue Jul 31, 2024
Because it can easily be cut off in a slightly narrow editor
Fix #221506
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Jul 31, 2024
Copy link

Issue marked as unreleased but unable to locate closing commit in repo history. If this was closed in a separate repo you can add the insiders-released label directly, or comment \closedWith someShaThatWillbeReleasedWhenThisIsRelesed.

@vs-code-engineering vs-code-engineering bot removed the unreleased Patch has not yet been released in VS Code Insiders label Jul 31, 2024
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jul 31, 2024
@vs-code-engineering vs-code-engineering bot removed the unreleased Patch has not yet been released in VS Code Insiders label Jul 31, 2024
Copy link

		Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting `\closedWith someCommitSha`, or directly add the `insiders-released` label if you know this has already been releaased

@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 31, 2024
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 24, 2024
@rzhao271 rzhao271 added the verified Verification succeeded label Aug 28, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants