Terminal: Inline chat recommendation is too distracting

[aeschli]

Version: 1.90.0-insider
Commit: 50f2b2e
Date: 2024-05-28T05:49:03.008Z
Electron: 29.4.0
ElectronBuildId: 9593362
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Linux x64 5.14.0-1048-oem

• Have copilot installed and open the terminal

The inline chat recommendation uses the same colors as the terminal prompt and I find it too distracting.
Would be better if it uses the color that ghost text in the editor uses.

[Tyriar]

Colors look very close to the editor for Dark Modern:

I notice they're not italic though, if the colors differ we should make them align (is the gray not as dark?)

[Tyriar]

Yes we need to align colors:

[aeschli]

IMO just aligning with the colors that are used in the empty editor will not help much.
The empty editor doesn't have any other content, so the hint doesn't conflict with regular content.

We should use the inline-hint colors instead, that are designed to go together with regular text.

[Tyriar]

@aeschli it's more impactful than that not just to align with the editor but because it doesn't show very often. I think the conditions are that it must be the only terminal in addition to no other commands being run.

Without the blue:

Using editorGhostText.foreground:

[Tyriar]

Put a poll out in #ux

[Tyriar]

Bunch of discussion happening, we'll enable only on Insiders for this release.