-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared process disappears out of nothing #212664
Comments
Anything in |
Found out why I had no crash reports: #212671 |
Here it is! Crash report
|
I'm getting different crash reasons actually. Just happened again last night. Out of memory? Weird. Crash report
|
Mostly related: I discovered a bug yesterday that caused the extension to download itself repeatedly until it succeeded -
I fixed it yesterday. @joaomoreno Lets check the memory chart today with today's insider. |
Thanks @deepak1556 for showing me how to attach devtools to the shared process. Details:
Indeed an allocation timeline quickly shows bursts of memory allocation every time I focus VS Code back from another app. In the following recording, I focused it three times. Each of these are ~60MB of memory that won't ever be garbage collected. |
I could only find the string |
🥳 Alright, root cause found! TL;DR Instantiation services now hold on to their children, which surfaces a memory leak in a part of the Settings Sync area which runs in the shared process. I am the only one who seems to repro this due to the following snowflake conditions:
In essence:
Throughout a normal day, in which I focus in and out of VS Code multiple times, these incremental 60MB allocations would eventually result in a OOM crash. 💥 A couple more follow up items:
Fixed by #212873 |
From #212103
It's happened to me at least 4 times in the last 2 weeks, I open up a previously running Code Insiders and the extension view loads forever. The process explorer shows that the shared process is gone. There are no crashes in
Crashpad/completed
.The text was updated successfully, but these errors were encountered: