Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should shellIntegration.executeCommand throw #208661

Closed
jrieken opened this issue Mar 25, 2024 · 1 comment · Fixed by #208805
Closed

Should shellIntegration.executeCommand throw #208661

jrieken opened this issue Mar 25, 2024 · 1 comment · Fixed by #208805
Assignees
@Tyriar
Labels
api bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Milestone
March 2024

Comments

@jrieken
Copy link
Member

jrieken commented Mar 25, 2024 •
edited
Loading

Testing #208462

The docs says "Note This is not guaranteed to work as shell integration must be activated." which is confusing because it should

  • then not be possible to reach TerminalShellIntegration#executeCommand
  • or throw an error
@Tyriar
Copy link
Member

Tyriar commented Mar 25, 2024

Stale comment 👍

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug api terminal-shell-integration Shell integration, command decorations, etc. labels Mar 25, 2024
@Tyriar Tyriar added this to the March 2024 milestone Mar 25, 2024
Tyriar added a commit that referenced this issue Mar 26, 2024
@Tyriar
Remove stale comment
feb1c25 
Fixes #208661
@Tyriar Tyriar mentioned this issue Mar 26, 2024
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 26, 2024
@jrieken jrieken added the verified Verification succeeded label Mar 27, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
api bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Projects
None yet
Milestone
March 2024
Development

Successfully merging a pull request may close this issue.

Remove stale comment microsoft/vscode
3 participants
@jrieken @Tyriar @vscodenpa