Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't drag and drop diff resource into editor #181367

Closed
mjbvz opened this issue May 3, 2023 · 0 comments · Fixed by #181374
Closed

Can't drag and drop diff resource into editor #181367

mjbvz opened this issue May 3, 2023 · 0 comments · Fixed by #181374
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
May 2023

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented May 3, 2023

Type: Bug

  1. Open a diff editor from the scm view
  2. Try dragging its tab into another editor while holding shift

Bug
Nothing happens

VS Code version: Code - Insiders 1.78.0-insider (Universal) (657bb89, 2023-05-02T11:25:59.772Z)
OS version: Darwin x64 22.4.0
Modes:
Sandboxed: Yes

System Info
Item Value
CPUs Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) 6, 6, 5
Memory (System) 32.00GB (0.34GB free)
Process Argv --crash-reporter-id 48781ca2-1705-4f64-9bab-325055aab55d
Screen Reader no
VM 0%
@mjbvz mjbvz self-assigned this May 3, 2023
@mjbvz mjbvz added this to the May 2023 milestone May 3, 2023
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label May 3, 2023
mjbvz added a commit to mjbvz/vscode that referenced this issue May 3, 2023
@mjbvz
Set text/uri-list when dragging editor resources
9444ef1 
Fixes microsoft#181367
Fixes microsoft#181373

This moves the setting of `text/uri-list` to happen on drag instead of on drop. This allows dropping editors as `text/uri-list` across applications

Note that due to https://bugs.chromium.org/p/chromium/issues/detail?id=239745, we can only set a single uri in the real `text/uri-list` type
@mjbvz mjbvz mentioned this issue May 3, 2023
Merged
mjbvz added a commit that referenced this issue May 3, 2023
@mjbvz
Set text/uri-list when dragging editor resources (#181374)
63f0154 
Fixes #181367
Fixes #181373

This moves the setting of `text/uri-list` to happen on drag instead of on drop. This allows dropping editors as `text/uri-list` across applications

Note that due to https://bugs.chromium.org/p/chromium/issues/detail?id=239745, we can only set a single uri in the real `text/uri-list` type
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 3, 2023
@rzhao271 rzhao271 added the verified Verification succeeded label May 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
May 2023
Development

Successfully merging a pull request may close this issue.

Set text/uri-list when dragging editor resources mjbvz/vscode
3 participants
@rzhao271 @mjbvz @vscodenpa