Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve shell integration SetMark sequence constraints #160355

Closed
meganrogge opened this issue Sep 7, 2022 · 0 comments · Fixed by #160458
Closed

improve shell integration SetMark sequence constraints #160355

meganrogge opened this issue Sep 7, 2022 · 0 comments · Fixed by #160458
Assignees
@meganrogge
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders tasks Task system issues terminal-shell-integration Shell integration, command decorations, etc.
Milestone
September 2022

Comments

@meganrogge
Copy link
Contributor

It's currently very strict about the param count but not strict at all about the validity of the params, we should go one of 2 routes:

  • Fail on anything unexpected
  • Ignore unrecognized params

I think the latter is probably best which means we should remove the <= 2 param assertion.

Originally posted by @Tyriar in #158313 (comment)
@meganrogge meganrogge self-assigned this Sep 7, 2022
@meganrogge meganrogge added tasks Task system issues debt Code quality issues terminal-shell-integration Shell integration, command decorations, etc. labels Sep 7, 2022
@meganrogge meganrogge added this to the September 2022 milestone Sep 7, 2022
meganrogge added a commit that referenced this issue Sep 8, 2022
@meganrogge
fix #160355
ac9ca67
@meganrogge meganrogge mentioned this issue Sep 8, 2022
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@meganrogge meganrogge

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders tasks Task system issues terminal-shell-integration Shell integration, command decorations, etc.
Projects
None yet
Milestone
September 2022
Development

Successfully merging a pull request may close this issue.

ignore invalid parameters microsoft/vscode
2 participants
@meganrogge @vscodenpa