Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide run recent command sorting that behaves closer to reverse-i-search #154016

Closed
Tyriar opened this issue Jul 3, 2022 · 1 comment · Fixed by #154305
Closed

Provide run recent command sorting that behaves closer to reverse-i-search #154016

Tyriar opened this issue Jul 3, 2022 · 1 comment · Fixed by #154305
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal-shell-integration Shell integration, command decorations, etc.
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 3, 2022

I've had run recent command on ctrl+r for a while. It does provide a nice experience with an overview of what you have been doing, but the more you use it the less relevant the search results become. Since the sorting of the groups is already in reverse search order, the groups could still remain (current session, then previous session, then history).

Instead of a new command this could reuse the same one with an argument to configure a keybinding to do either and also a persisted sorting toggle at the top of the quick pick.

@Tyriar Tyriar added feature-request Request for new features or functionality terminal-shell-integration Shell integration, command decorations, etc. labels Jul 3, 2022
@Tyriar Tyriar added this to the July 2022 milestone Jul 3, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Jul 6, 2022

WIP:

		quickPick.title = 'Run Recent Command';
		quickPick.buttons = [
			{
				alwaysVisible: true,
				iconClass: Codicon.sortPrecedence.classNames,
				tooltip: nls.localize('close', "Toggle sorting")
			}
		];
		return new Promise<void>(r => {
			quickPick.onDidTriggerButton(e => {
				console.log('onDidTriggerButton e', e);
			});

Tyriar added a commit that referenced this issue Jul 6, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal-shell-integration Shell integration, command decorations, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants