-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a real button for lazy variables #143602
Comments
I could easily use that type of button, but I'm worried that it wouldn't be more obvious as a button since it doesn't have a background color except on hover, and in this view we already use |
If the background color is always shown, then there isn't any change when you hover it. |
yes, that's the reason why I proposed the button: to increase discoverability But I'm not insisting on the button... |
If we decide to go with a button, I'd say we use our common icon buttons that have the hover feedback so that it's consistent: CleanShot.2022-02-24.at.09.25.11.mp4 |
@misolori yep, makes sense: if the button neither looks like an ellipsis nor like some random text, then it will work because users will be curious to hover over it or click on it. |
I'm not crazy about that icon. We just replaced it in notebooks with the |
@weinand that icon can work too, I'm fine with whatever icon we decide to go with as long as it uses the same stylings as our icon in the toolbars (with the hover feedback) |
I'm also not sure about that icon which looks like "refresh"/"reload". @connor4312 suggested an eye, which I don't hate Although with no context, I wonder whether the codicon looks enough like an eye |
I like the concept of an "eye" but not the octicon suggested above. from https://primer.style/octicons/eye-24 Another candidate: from https://primer.style/octicons/unfold-24 It is similar to the icon suggested by @misolori above: but doesn't look like a "star" |
@misolori do you think it's worth taking another look at the shape of the eye codicon? |
The new icon actually looks more like an eye because the distance between the pupil and the eyebrow is smaller. |
I strongly prefer the new version, thanks @misolori! |
illuminati symbol? This was a terrible and unnecessary change. The ellipse was a better lazy variable indicator, it made scrolling through a list of nodes or elements easier than this weird-looking eye. At least allow a setting to choose preference. |
Why did you think VSCode needed this. Such a mistake! |
Testing #143572
Currently the string
(...)
is used to indicate that a variables is "lazy" and that an additional click is required to retrieve the variable's value:To make more obvious that the
(...)
is not a value but an interaction element, I propose to use a button:@misolori what do you think?
The text was updated successfully, but these errors were encountered: