Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode.dev: Make UI more stable when opening a PR URL #136660

Closed
egamma opened this issue Nov 8, 2021 · 1 comment · Fixed by microsoft/vscode-pull-request-github#3090
Closed

vscode.dev: Make UI more stable when opening a PR URL #136660

egamma opened this issue Nov 8, 2021 · 1 comment · Fixed by microsoft/vscode-pull-request-github#3090
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded vscode.dev Issues related to vscode.dev
Milestone
November 2021

Comments

@egamma
Copy link
Member

egamma commented Nov 8, 2021

Open a PR from the navbar, e.g. https://vscode.dev/github/microsoft/vscode/pull/124803

Observe the activity bar and notice the appearance of:

  • the Explorer view
  • the GHPRI view
  • the Explorer view
  • the GHPRI view
@egamma egamma added the vscode.dev Issues related to vscode.dev label Nov 8, 2021
@egamma egamma added this to the November 2021 milestone Nov 8, 2021
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Nov 8, 2021
@alexr00
Copy link
Member

alexr00 commented Nov 8, 2021

Turns out this is coming from GHPRI. There was some flow added 9 months ago that aimed to improve the perceived performance of loading all the views. There is a gap between when views are shown and hidden, which causes the Explorer view to show in-between.

alexr00 added a commit to microsoft/vscode-pull-request-github that referenced this issue Nov 8, 2021
@alexr00
Improve view+welcome show/hide timing
977acd8 
Fixes microsoft/vscode#136660
@alexr00 alexr00 mentioned this issue Nov 8, 2021
Merged
@kieferrm kieferrm mentioned this issue Nov 8, 2021
Closed
82 tasks
@lramos15 lramos15 added the verified Verification succeeded label Dec 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded vscode.dev Issues related to vscode.dev
Projects
None yet
Milestone
November 2021
Development

Successfully merging a pull request may close this issue.

Improve view+welcome show/hide timing microsoft/vscode-pull-request-github
3 participants
@egamma @lramos15 @alexr00