Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve discoverability of cell folding #132690

Closed
miguelsolorio opened this issue Sep 8, 2021 · 5 comments
Closed

Improve discoverability of cell folding #132690

miguelsolorio opened this issue Sep 8, 2021 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders notebook-folding notebook-rendering on-testplan ux User experience issues
Milestone

Comments

@miguelsolorio
Copy link
Contributor

Summary

This issue explores how we could improve the discoverability of cell folding. We currently support markdown folding via the chevron, via code cells for both input and output using the context menus, and we also have code folding when line numbers are enabled.

The secondary issue is that when markdown cells are folded, it's difficult to tell what cells are folded underneath as there is no indicator. You also can't run any of the folded cells inside of the markdown region (unless you run all cells).

Design exploration

One idea is to use the left gutter for folding (similar to JupyterLab). One downside is that this repeats functionality via our chevron, but we have limited space for code cells and also have a split run button (which has a small chevron).

CleanShot 2021-09-08 at 13 23 35

And for folding markdown regions, it would be great to show underneath what cells are hidden with an ability to run those cells. There's other questions with how do we surface additional information about those cells (run state, execution count, etc.) which may or not be useful. At the minimum, using the placeholder text with a run button will solve a large amount of frustration with knowing how many cells are folded and if they are running. This would also be done in parallel with #130611 for showing what cells are actively running.

CleanShot 2021-09-08 at 13 52 06

@tanhakabir
Copy link
Contributor

I think a tooltip saying "hide cell" when they hover over the gutter could be helpful here as well

@miguelsolorio
Copy link
Contributor Author

@roblourens I believe the design exploration is done on this issue, let me know if you need anything else from me.

@roblourens
Copy link
Member

Can you link to those figmas? I don't know how to discover things in Figma

@miguelsolorio
Copy link
Contributor Author

Here's a link to the Figma: https://www.figma.com/file/I4lDqeDSAT4n3V47aZltLg/Notebook-Cell-Folding?node-id=12%3A1497

@roblourens roblourens modified the milestones: On Deck, January 2022 Jan 21, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders notebook-folding notebook-rendering on-testplan ux User experience issues
Projects
None yet
Development

No branches or pull requests

6 participants
@roblourens @rebornix @DonJayamanne @tanhakabir @miguelsolorio and others