Testing: bad inline actions contrast upon selected tree item

[isidorn]

Refs: microsoft/vscode-python#17040

I suggest to use white for action icons when selected item and hovered, since black on blue does not give it enough contrast. All other trees do this as far as I know.

Here's open editors as an example

fyi @karthiknadig @misolori

[miguelsolorio]

@isidorn this is completely dependent on your theme, our default dark/light theme show them appropriately:

[connor4312]

Which theme are you using @isidorn? It seems like in is globally styled by

vscode/src/vs/base/browser/ui/list/listWidget.ts

Line 791 in 77905c8

content.push(`.monaco-list${suffix}:focus .monaco-list-row.selected .codicon { color: ${styles.listActiveSelectionIconForeground}; }`);

which should be applied herer

[miguelsolorio]

That looks like the GitHub Sharp theme which has the same style applied in other list views:

Setting the following would address this in the theme:

  "workbench.colorCustomizations": {
    "[GitHub Sharp]": {
      "list.activeSelectionIconForeground": "#f0f0f0"
    },
  }

[isidorn]

Sorry for the noise.
I will provide a PR against the theme. No need to keep this open in VS Code.

[isidorn]

Good point by @joaomoreno
@misolori @aeschli Why isn't list.activeSelectionIconForeground inheriting from list.activeSelectionForeground?

[joaomoreno]

It feels like it should be the default, instead of the current null.

[miguelsolorio]

The default is null because majority of themes have different active states in lists + suggest widget + quick pick and there is not a single solution that solves it for all, see #125998 #126288 for details.