-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call Stack bounces when short-lived second requests start/stop #122775
Comments
Please file this against the php debug extension that you are using. |
I see a similar situation with the mock debugger, when a new debugging request has started the currently focused stack thread loses focus and the new break point it automatically focused. Even when the new request has continued, the focus never goes back, nor is there a way to know readily where the focus was. Additionally when the first request was in the stack trace, it did not act as a collapsible entity, however after the second request was added, the stack trace window was rearranged so that each request was collapsible, though after the second request was completed the first request did maintain it's status as a collapsible entity. Given the nature of the mock debugger I am not sure if this is caused by the fact that you have to execute a new request manually. I chose to add a new test2.md file and a new launch.json entry to simulate. |
Also from what I can tell this is definitely VSCode that tries to show the stack traces in a different format if there is one of them vs. if there are multiple. Screen shots are attached to this issue: xdebug/vscode-php-debug#558 (comment) |
If you can repro with mock debug can you write concise exact steps so I can repro on my machine as well. Thanks |
|
So the gist is: "the session gets auto collapsed when a new session pauses on a breakpoint". Right? |
Sort of, the session originally isn't in a collapsible section and when another request is shown on the call stack (whether is it a paused or just showing as running) it transforms into a collapsed section. Then when the other session is no longer there it becomes a non collapsible list again, losing ones place. |
Ok, let me reopen and I can investigate more in the future |
I agree, we should not collapse a paused session when a new session arrives. |
I still hit #122775 (comment) using Mock Debug |
That is expected. When there is only one session we do not show it in the call stack view (to simplify). Thus in that case it is not collapsable. What I fixed here is No further changes planned here, as we did not receive any other negative feedback regarding this behaviour |
This doesn't seem to have been fixed. The call stack still collapses when a new one is added @rzhao271 is right and the issue isn't resolved. If you happened to have fixed some other issue as a result, happy accident, however the behavior described above still persists. |
Ok, let's reopen. I will follow steps from #122775 (comment) |
Somehow forgot to forward this to @roblourens when he took over Debug. |
This still reproes |
Notes- we have this code that autoexpands sessions:
What I see is slightly different than the screenshots above, which is that the first session remains expanded, but the new one is collapsed, so your focus can stay on the current one. This seems not that bad to me. |
Issue Type: Bug
When using the PHP debugger I have a request paused and awaiting, however while that request is running other requests are also running but not pausing, as expected. The problem is that while there is only one request in the call stack, the call stack for the paused request is expanded, however when a second request is running the paused call stack gets collapsed and it shows two requests, with the paused request having an expansion arrow. Then the second request ends and the call stack again shows the full single request's call stack. Because of the nature of the application and my local dev environment, this is constantly happening, and focusing on anything or expanding it doesn't prevent me form losing my place.
VS Code version: Code 1.55.2 (3c4e3df, 2021-04-13T09:35:57.887Z)
OS version: Windows_NT x64 10.0.19041
System Info
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: enabled_on
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Extensions (47)
A/B Experiments
The text was updated successfully, but these errors were encountered: