Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files supplied by a FileSystemProvider do not persist in QuickOpen history #122314

Closed
gjsjohnmurray opened this issue Apr 27, 2021 · 2 comments
Closed
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@gjsjohnmurray
Copy link
Contributor

Issue Type: Bug

When a workspace root uses a FileSystemProvider extension to serve files, the files opened from there only appear in QuickOpen's "recently opened" list while they remain open. As soon as they are closed they get removed from this history.

This seems to be the cause:

// for now, only prefer well known schemes that we control to prevent
// issues such as https://github.com/microsoft/vscode/issues/85204
// from being used as resource inputs
// resource inputs survive editor disposal and as such are a lot more
// durable across editor changes and restarts
const validResourceEditorInputScheme =
resource?.scheme === Schemas.file ||
resource?.scheme === Schemas.vscodeRemote ||
resource?.scheme === Schemas.userData ||
resource?.scheme === this.pathService.defaultUriScheme;

This behaviour adversely affects the user experience when working with virtual filesystems.

Pinging @bpasero who apparently added this restriction in response to #85204

VS Code version: Code - Insiders 1.56.0-insider (9a4d524, 2021-04-27T06:15:26.914Z)
OS version: Windows_NT x64 10.0.19042

@bpasero
Copy link
Member

bpasero commented Apr 27, 2021

/duplicate #108935

@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

3 participants
@bpasero @gjsjohnmurray and others