Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git FS: needs to emit events when file is gone #85204

Closed
bpasero opened this issue Nov 20, 2019 · 2 comments
Closed

Git FS: needs to emit events when file is gone #85204

bpasero opened this issue Nov 20, 2019 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-history History item issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Nov 20, 2019

The history listens to file events and removes entries upon delete. We need to send this from git fs when an editor is no longer valid, otherwise these stick around:

image

@bpasero
Copy link
Member Author

bpasero commented Nov 20, 2019

this.remove(e); // remove from history files that got deleted or moved

@joaomoreno
Copy link
Member

joaomoreno commented Nov 20, 2019

@bpasero These files are never gone, an old version of a file always exists... I'm not really sure I can do anything here.

I believe this support should come from the platform: I don't want these resources to show up in these places at all. The same way I can specify that my file system is readonly, there should be more attributes on a file system which let me control how it behaves in the workbench.

@joaomoreno joaomoreno assigned bpasero and unassigned joaomoreno Nov 20, 2019
@bpasero bpasero added this to the December 2019 milestone Nov 20, 2019
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-history History item issues labels Nov 20, 2019
@bpasero bpasero added the verified Verification succeeded label Dec 10, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-history History item issues
Projects
None yet
Development

No branches or pull requests

2 participants