-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variables are not displayed when debugging two sessions and one ends #113742
Comments
Happy New Year, Yes I can reproduce this with js-debug adapter which has child sessions. The issue is that when a debug session is stopped we do not focus the stack frame, but only the session. What this means is that the variables does not display anything since a stack frame is not focused. |
@yannickowow just to check if you can still reproduce this with latest vscode insiders? Since we have improved automatic switching of focus of sessions? |
Using
I can still reproduce this issue. lab2-1628106008472.mp4 |
@yannickowow this works just fine for me with js-debug and latest Insiders. Here's a gif where I am doing the same thing as you. |
Now I pushed the fix for the new issue you found. It would be great if you can re-try tomorrow with vscode insiders and try to investigate more. The actual line is this one
This is a permalink, so the line should be definite. Just try to figure out how the focus behaves, and if the focus is properly passed to the remaining |
I did some testing, here is my understanding. However, we are setting a focus on a Before: const { session } = getStackFrameThreadAndSessionToFocus(this.model, undefined, undefined, undefined, focusedSession);
this.viewModel.setFocus(undefined, undefined, session, false); After: const { session, thread, stackFrame } = getStackFrameThreadAndSessionToFocus(this.model, undefined, undefined, undefined, focusedSession);
this.viewModel.setFocus(stackFrame, thread, session, false); With further testing, to display these variables we only need to focus a Here is a record with the HAMITI_YANIS_RenduCrypto_1_-1629203782288.mp4 |
@yannickowow that looks like a reasonable change. Would you like to create a PR with that change, or would you like me to push it? |
I opened a PR about this change |
- When a session ends, it should focus another session and correctly display variables - Here, focus the first session and the Thread 1 - Should display variables accordingly Fix #113742
[debugService #113742] variable display on debug session ending
Awesome. I merged it. Should be in insiders tomorrow. Let me know how it goes once you try it out with the built vs code. |
👍 |
Great, adding verified label. |
- When a session ends, it should focus another session and correctly display variables - Here, focus the first session and the Thread 1 - Should display variables accordingly Fix microsoft#113742
Hi,
First of all, Happy new Year!
I submit here an issue regarding to
Variables
in Debug View.Steps to Reproduce:
Variables are correctly displayed when switching one session to another, but they are not displayed after a session ended.
Regards.
EDIT: If you try the same steps with 3 sessions:
Does this issue occur when all extensions are disabled?: N/A : Need at least one extension to debug.
EDIT2: This ""problem"" is due to
stackFrame
lost focus, which happens when debuggee stops. It can be an expected behaviour. If so, I can close this issue.The text was updated successfully, but these errors were encountered: