Fix #145685

microsoft · Mar 22, 2022 · c4370d1 · c4370d1
1 parent 637af81
commit c4370d1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/vs/workbench/api/browser/mainThreadEditorTabs.ts b/src/vs/workbench/api/browser/mainThreadEditorTabs.ts
@@ -474,7 +474,7 @@ export class MainThreadEditorTabs implements MainThreadEditorTabsShape {
 		}
 		// Loop over keys of the groups map and call closeEditors
 		for (const [group, editors] of groups) {
-			group.closeEditors(editors, { preserveFocus });
+			await group.closeEditors(editors, { preserveFocus });
 		}
 	}
 	//#endregion

diff --git a/src/vscode-dts/vscode.proposed.tabs.d.ts b/src/vscode-dts/vscode.proposed.tabs.d.ts
@@ -141,6 +141,7 @@ declare module 'vscode' {
 		/**
 		 * Closes the tab. This makes the tab object invalid and the tab
 		 * should no longer be used for further actions.
+		 * Note: In the case of a dirty tab, a confirmation dialog will be shown which may be cancelled. If cancelled the tab is still valid
 		 * @param tab The tab to close, must be reference equal to a tab given by the API
 		 * @param preserveFocus When `true` focus will remain in its current position. If `false` it will jump to the next tab.
 		 */