Don't action right click when target is scroll bar

Fixes #223358
microsoft · Jul 26, 2024 · 9a02ce1 · 9a02ce1
1 parent c47678c
commit 9a02ce1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/vs/workbench/contrib/terminal/browser/terminalEditor.ts b/src/vs/workbench/contrib/terminal/browser/terminalEditor.ts
@@ -124,7 +124,11 @@ export class TerminalEditor extends EditorPane {
 		}
 		this._register(dom.addDisposableListener(this._editorInstanceElement, 'mousedown', async (event: MouseEvent) => {
 			const terminal = this._terminalEditorService.activeInstance;
-			if (this._terminalEditorService.instances.length === 0 || !terminal) {
+			if (
+				this._terminalEditorService.instances.length === 0 ||
+				!terminal ||
+				dom.isHTMLElement(event.target) && event.target.classList.contains('scrollbar')
+			) {
 				return;
 			}
 

diff --git a/src/vs/workbench/contrib/terminal/browser/terminalTabbedView.ts b/src/vs/workbench/contrib/terminal/browser/terminalTabbedView.ts
@@ -332,7 +332,11 @@ export class TerminalTabbedView extends Disposable {
 		}));
 		this._register(dom.addDisposableListener(terminalContainer, 'mousedown', async (event: MouseEvent) => {
 			const terminal = this._terminalGroupService.activeInstance;
-			if (this._terminalGroupService.instances.length === 0 || !terminal) {
+			if (
+				this._terminalGroupService.instances.length === 0 ||
+				!terminal ||
+				dom.isHTMLElement(event.target) && event.target.classList.contains('scrollbar')
+			) {
 				this._cancelContextMenu = true;
 				return;
 			}