chore: rm unused dyld entitlement and env variable filtering (#220059)

microsoft · Jul 5, 2024 · 796dfbb · 796dfbb
1 parent 20775fd
commit 796dfbb
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 10 deletions.
diff --git a/build/azure-pipelines/darwin/helper-plugin-entitlements.plist b/build/azure-pipelines/darwin/helper-plugin-entitlements.plist
@@ -6,8 +6,6 @@
 	<true/>
 	<key>com.apple.security.cs.allow-unsigned-executable-memory</key>
 	<true/>
-	<key>com.apple.security.cs.allow-dyld-environment-variables</key>
-	<true/>
 	<key>com.apple.security.cs.disable-library-validation</key>
 	<true/>
 </dict>

diff --git a/src/vs/base/common/processes.ts b/src/vs/base/common/processes.ts
@@ -3,7 +3,7 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { IProcessEnvironment, isLinux, isMacintosh } from 'vs/base/common/platform';
+import { IProcessEnvironment, isLinux } from 'vs/base/common/platform';
 
 /**
  * Options to be passed to the external program or shell.
@@ -140,13 +140,6 @@ export function removeDangerousEnvVariables(env: IProcessEnvironment | undefined
 	// See https://github.com/microsoft/vscode/issues/130072
 	delete env['DEBUG'];
 
-	if (isMacintosh) {
-		// Unset `DYLD_LIBRARY_PATH`, as it leads to process crashes
-		// See https://github.com/microsoft/vscode/issues/104525
-		// See https://github.com/microsoft/vscode/issues/105848
-		delete env['DYLD_LIBRARY_PATH'];
-	}
-
 	if (isLinux) {
 		// Unset `LD_PRELOAD`, as it might lead to process crashes
 		// See https://github.com/microsoft/vscode/issues/134177