Skip to content

Commit

Permalink
testing: adopt feedback for call stack api (#224308)
Browse files Browse the repository at this point in the history
  • Loading branch information
connor4312 authored Jul 30, 2024
1 parent b8606d6 commit 686611a
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/vs/workbench/api/common/extHostTypeConverters.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1891,7 +1891,7 @@ export namespace TestMessage {
stackTrace: (message as vscode.TestMessage2).stackTrace?.map(s => ({
label: s.label,
position: s.position && Position.from(s.position),
uri: s.file && URI.revive(s.file).toJSON(),
uri: s.uri && URI.revive(s.uri).toJSON(),
})),
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/vs/workbench/api/common/extHostTypes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4107,7 +4107,7 @@ export class TestMessageStackFrame {
*/
constructor(
public label: string,
public file?: vscode.Uri,
public uri?: vscode.Uri,
public position?: Position,
) { }
}
Expand Down
4 changes: 2 additions & 2 deletions src/vscode-dts/vscode.proposed.testMessageStackTrace.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ declare module 'vscode' {
* The location of this stack frame. This should be provided as a URI if the
* location of the call frame can be accessed by the editor.
*/
file?: Uri;
uri?: Uri;

/**
* Position of the stack frame within the file.
Expand All @@ -33,6 +33,6 @@ declare module 'vscode' {
* @param file The file URI of the stack frame
* @param position The position of the stack frame within the file
*/
constructor(label: string, file?: Uri, position?: Position);
constructor(label: string, uri?: Uri, position?: Position);
}
}

0 comments on commit 686611a

Please sign in to comment.