Skip to content

Commit

Permalink
rename channel action processBinary
Browse files Browse the repository at this point in the history
  • Loading branch information
meganrogge committed Apr 2, 2021
1 parent c61393b commit 60e19db
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions src/vs/workbench/contrib/terminal/browser/remotePty.ts
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,8 @@ export class RemotePty extends Disposable implements ITerminalChildProcess {
handleData(e: string | IProcessDataEvent) {
this._onProcessData.fire(e);
}
async processBinary(e: string): Promise<void> {
this._remoteTerminalChannel.processBinary(this._id, e);
processBinary(e: string): Promise<void> {
return this._remoteTerminalChannel.processBinary(this._id, e);
}
handleExit(e: number | undefined) {
this._onProcessExit.fire(e);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ export class RemoteTerminalService extends Disposable implements IRemoteTerminal
if (!this._remoteTerminalChannel) {
throw new Error('Cannot reduce grace time when there is no remote');
}
this._remoteTerminalChannel.reduceConnectionGraceTime();
return this._remoteTerminalChannel.reduceConnectionGraceTime();
}

public async getTerminalLayoutInfo(): Promise<ITerminalsLayoutInfo | undefined> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export class RemoteTerminalChannelClient {
return this._channel.listen<{ id: number, event: IProcessDataEvent | string }>('$onProcessDataEvent');
}
public get onProcessBinary(): Event<{ id: number, event: string }> {
return this._channel.listen<{ id: number, event: string }>('$onProcessBinaryEvent');
return this._channel.listen<{ id: number, event: string }>('$onProcessBinary');
}
public get onProcessExit(): Event<{ id: number, event: number | undefined }> {
return this._channel.listen<{ id: number, event: number | undefined }>('$onProcessExitEvent');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export class LocalPty extends Disposable implements ITerminalChildProcess {
if (this._inReplay) {
return;
}
this._localPtyService.processBinary(this.id, data);
return this._localPtyService.processBinary(this.id, data);
}
input(data: string): void {
if (this._inReplay) {
Expand Down

0 comments on commit 60e19db

Please sign in to comment.