Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine what type of shell subprocesses are being executed with #2422

Closed
brettcannon opened this issue Aug 21, 2018 · 3 comments
Closed

Determine what type of shell subprocesses are being executed with #2422

brettcannon opened this issue Aug 21, 2018 · 3 comments
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@brettcannon
Copy link
Member

E.g. is it a login shell, etc. That way we can tell e.g. bash users to make sure they set things as appropriate in their .bash_profile instead of .bashrc (or whatever the appropriate answer is).

We should also see if we can control what kind of shell is used when executing subprocesses and what the performance overhead is in changing it to see if we can simply execute everything in a way that people expect.

@brettcannon brettcannon added needs verification debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Aug 21, 2018
@brettcannon
Copy link
Member Author

@brettcannon
Copy link
Member Author

microsoft/vscode#57551 (comment) has some details of how to make sure we are calling through the shell in Node (i.e. exec() or spawn() with an option set).

@brettcannon
Copy link
Member Author

We are executing Python with spawn() and I couldn't find any calls where we were using shell: true.

There are some notes in the spawn() docs about potential caveats when executing with the shell.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

No branches or pull requests

1 participant