Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into cost of executing all commands in shell process #2363

Closed
brettcannon opened this issue Aug 9, 2018 · 2 comments
Closed

Look into cost of executing all commands in shell process #2363

brettcannon opened this issue Aug 9, 2018 · 2 comments
Labels
area-internal Label for non-user facing issues feature-request Request for new features or functionality needs spike Label for issues that need investigation before they can be worked on.

Comments

@brettcannon
Copy link
Member

When we run commands in a system call we don't seem to inherit the current environment and we don't seem to execute in a shell. It might be good to see if (a) we can inherit the current environment, (b) execute in a shell, and (c) if there's any maintenance/perf cost to doing this. I suspect this will have less of a surprise for users if we can do this.

@brettcannon
Copy link
Member Author

#2422 determined that we are not executing in a shell.

@luabud luabud removed the -review- label Apr 8, 2020
@karthiknadig karthiknadig added area-internal Label for non-user facing issues needs spike Label for issues that need investigation before they can be worked on. and removed feature-* labels May 13, 2020
@brettcannon
Copy link
Member Author

Thanks to conda run this is less of a concern. Plus with the shift to tools extensions and language servers this is less of a concern here. Closing as out of date.

@brettcannon brettcannon closed this as not planned Won't fix, can't repro, duplicate, stale Dec 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-internal Label for non-user facing issues feature-request Request for new features or functionality needs spike Label for issues that need investigation before they can be worked on.
Projects
None yet
Development

No branches or pull requests

3 participants