fix codeql warnings (#10)

* fix codeql warnings * Update src/statement.h Co-authored-by: Robo <hop2deep@gmail.com> Co-authored-by: Robo <hop2deep@gmail.com>
microsoft · Nov 16, 2021 · 7112bf8 · 7112bf8
1 parent a675471
commit 7112bf8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/statement.cc b/src/statement.cc
@@ -840,6 +840,10 @@ void Statement::GetRow(Row* row, sqlite3_stmt* stmt) {
     for (int i = 0; i < rows; i++) {
         int type = sqlite3_column_type(stmt, i);
         const char* name = sqlite3_column_name(stmt, i);
+        if (name == NULL) {
+            assert(false);
+        }
+
         switch (type) {
             case SQLITE_INTEGER: {
                 row->push_back(new Values::Integer(name, sqlite3_column_int64(stmt, i)));

diff --git a/src/statement.h b/src/statement.h
@@ -86,7 +86,7 @@ class Statement : public Napi::ObjectWrap<Statement> {
             callback.Reset(cb_, 1);
         }
         virtual ~Baton() {
-            for (unsigned int i = 0; i < parameters.size(); i++) {
+            for (size_t i = 0; i < parameters.size(); i++) {
                 Values::Field* field = parameters[i];
                 DELETE_FIELD(field);
             }