Fix rename ResponseError not being passed onto VSCode #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gama11
added a commit
to vshaxe/vshaxe
that referenced
this pull request
Jun 30, 2017
The fix for microsoft/vscode-languageserver-node#220 is now also included.
|
@Gam11: thanks for the PR. However I fixed this differently since we usually avoid to throw with promises. The problem was that the code used Promise#resolve instead of Promise#reject. |
|
That fix doesn't really help with the original issue - VS Code still shows "No result" instead of the error message from the server. |
|
Seems to be a VS Code issue. Opened microsoft/vscode#37808 |
|
This is actually still an issue with VSCode 1.21.0 and vscode-languageclient 4.0.0: I'm not sure which of the two is at fault, but this error shows up in the dev console after a failed rename: I gave your test case from microsoft/vscode#37808 a try, and that works as expected. |
This was referenced Mar 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to return a
ResponseErrorfrom the rename method in the Haxe language server to display an error in the UI (like the TypeScript language server does in some siutations, example).However, no matter what error code I used, the end result was always the same, VSCode displays
"No result."and the language client just logs it to the output channel:This is probably not a proper solution, and there might be other methods that are affected similarly, but it does fix my issue: