-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renderer changes for widgets renderer + controller function change #6120
Conversation
Jupyter side of renderer changes. Again. I need to test with VSCode main after notebook/dev merges. |
@DavidKutu I reverted your review on this, just since I added in the notebook controller changes as well. Was easier to test these together in one PR. |
Codecov Report
@@ Coverage Diff @@
## main #6120 +/- ##
======================================
- Coverage 71% 68% -4%
======================================
Files 398 398
Lines 26850 26846 -4
Branches 3950 3950
======================================
- Hits 19277 18404 -873
- Misses 5943 6917 +974
+ Partials 1630 1525 -105
|
Test failures expected due to breaking API change. Pushing. |
For #6118
package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed).