Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderer changes for widgets renderer + controller function change #6120

Merged
merged 3 commits into from
Jun 4, 2021

Conversation

IanMatthewHuff
Copy link
Member

For #6118

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@IanMatthewHuff IanMatthewHuff requested a review from a team as a code owner June 3, 2021 22:16
@IanMatthewHuff
Copy link
Member Author

Jupyter side of renderer changes. Again. I need to test with VSCode main after notebook/dev merges.

@IanMatthewHuff IanMatthewHuff changed the title renderer changes for widgets renderer renderer changes for widgets renderer + controller function change Jun 3, 2021
@IanMatthewHuff
Copy link
Member Author

@DavidKutu I reverted your review on this, just since I added in the notebook controller changes as well. Was easier to test these together in one PR.

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2021

Codecov Report

Merging #6120 (49ff82f) into main (e3ea1de) will decrease coverage by 3%.
The diff coverage is 50%.

@@          Coverage Diff           @@
##            main   #6120    +/-   ##
======================================
- Coverage     71%     68%    -4%     
======================================
  Files        398     398            
  Lines      26850   26846     -4     
  Branches    3950    3950            
======================================
- Hits       19277   18404   -873     
- Misses      5943    6917   +974     
+ Partials    1630    1525   -105     
Impacted Files Coverage Δ
...t/datascience/notebook/vscodeNotebookController.ts 28% <50%> (-50%) ⬇️
.../datascience/jupyter/kernels/cellExecutionQueue.ts 10% <0%> (-79%) ⬇️
src/client/datascience/jupyter/kernels/kernel.ts 9% <0%> (-67%) ⬇️
...lient/datascience/jupyter/kernels/cellExecution.ts 6% <0%> (-65%) ⬇️
...ent/datascience/jupyter/kernels/kernelExecution.ts 12% <0%> (-55%) ⬇️
...ient/datascience/jupyter/kernels/kernelProvider.ts 50% <0%> (-46%) ⬇️
...t/datascience/notebook/helpers/executionHelpers.ts 35% <0%> (-45%) ⬇️
src/client/datascience/kernelSocketWrapper.ts 45% <0%> (-42%) ⬇️
...ience/notebook/emptyNotebookCellLanguageService.ts 35% <0%> (-42%) ⬇️
... and 49 more

@IanMatthewHuff
Copy link
Member Author

Manual testing results testing against main branch (ipywidget renderer):
image
Basic ipywidgets load and work + we can see the renderer loading:
image

Manual testing against main branch (client_renderer copied from vscode-notebook-renderer build into jupyter client_renderer):
image
image
Logging for renderer activated:
image

The notebookController change was just a rename, basic tests by just swapping kernels and making sure that sys.executable updated after change. Also check that I hit a BP in the new handler function name.

@IanMatthewHuff
Copy link
Member Author

Manual run of our native notebook tests.
image

@IanMatthewHuff
Copy link
Member Author

Test failures expected due to breaking API change. Pushing.

@IanMatthewHuff IanMatthewHuff merged commit 596e820 into main Jun 4, 2021
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/rendererAPIChanges branch June 4, 2021 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants