Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary execution is created unnecessarily #10831

Closed
roblourens opened this issue Jul 15, 2022 · 0 comments · Fixed by #10833
Closed

Temporary execution is created unnecessarily #10831

roblourens opened this issue Jul 15, 2022 · 0 comments · Fixed by #10833
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug triage-needed Issue needs to be triaged verified Verification succeeded
Milestone
July 2022

Comments

@roblourens
Copy link
Member

For microsoft/vscode#150924, the extension is creating a temporary execution in case it needs to update outputs, but it turns out to be a case where the execution object isn't needed. Doing this creates unnecessary work on vscode's side
@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label Jul 15, 2022
@roblourens roblourens self-assigned this Jul 15, 2022
@roblourens roblourens added this to the July 2022 milestone Jul 15, 2022
@github-actions github-actions bot added the triage-needed Issue needs to be triaged label Jul 15, 2022
roblourens added a commit that referenced this issue Jul 15, 2022
@roblourens
Temporary execution is created unnecessarily
db96038 
Fixes #10831
@roblourens roblourens mentioned this issue Jul 15, 2022
Merged
roblourens added a commit that referenced this issue Jul 16, 2022
@roblourens
Temporary execution is created unnecessarily (#10833)
d37e4a9 
Fixes #10831
@connor4312 connor4312 added the verified Verification succeeded label Jul 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug triage-needed Issue needs to be triaged verified Verification succeeded
Projects
None yet
Milestone
July 2022
Development

Successfully merging a pull request may close this issue.

Temporary execution is created unnecessarily microsoft/vscode-jupyter
2 participants
@roblourens @connor4312