Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't validate source content of sources with hasSourceURL #1476

Closed
connor4312 opened this issue Dec 12, 2022 · 0 comments · Fixed by #1487
Closed

Don't validate source content of sources with hasSourceURL #1476

connor4312 opened this issue Dec 12, 2022 · 0 comments · Fixed by #1487
Assignees
@connor4312
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@connor4312
Copy link
Member 

    This is needed since we modify the .js file (to add the sourceURL) so contents don't line up. I will make a followup change in js-debug to not validate content on files with `hasSourceURL: true` since I think those will _never_ match, similar to sourcemapped content.

Originally posted by @connor4312 in microsoft/vscode#168921 (comment)
@connor4312 connor4312 added the bug Issue identified by VS Code Team member as probable bug label Dec 15, 2022
@connor4312 connor4312 self-assigned this Dec 15, 2022
@connor4312 connor4312 mentioned this issue Dec 16, 2022
Merged
connor4312 added a commit that referenced this issue Dec 16, 2022
@connor4312
fix: js files with sourceURLs opening readonly versions
0da8899 
Fixes #1476
connor4312 added a commit that referenced this issue Dec 16, 2022
@connor4312
fix: js files with sourceURLs opening readonly versions (#1487)
3477c7f 
Fixes #1476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: js files with sourceURLs opening readonly versions microsoft/vscode-js-debug
1 participant
@connor4312