fix: js files with sourceURLs opening readonly versions (#1487)

Fixes #1476

CHANGELOG.md

@@ -4,6 +4,7 @@ This changelog records changes to stable releases since 1.50.2. "TBA" changes he
 
 ## Nightly (only)
 
+- fix: js files with sourceURLs opening readonly versions ([#1476](https://github.com/microsoft/vscode-js-debug/issues/1476))
 - fix: breakpoints not setting in paths with special glob characters ([vscode#166400](https://github.com/microsoft/vscode/issues/166400))
 - fix: better handling of multiple glob patterns and negations ([#1479](https://github.com/microsoft/vscode-js-debug/issues/1479))
 - fix: skipFiles making catastrophic regexes ([#1469](https://github.com/microsoft/vscode-js-debug/issues/1469))

src/adapter/sources.ts

@@ -906,7 +906,7 @@ export class SourceContainer {
         : undefined,
       inlineSourceRange,
       runtimeScriptOffset,
-      this.launchConfig.enableContentValidation ? contentHash : undefined,
+      contentHash,
     );
 
     this._addSource(source);

src/adapter/threads.ts

@@ -103,7 +103,6 @@ export class ExecutionContext {
 export type Script = {
   url: string;
   scriptId: string;
-  hash: string;
   source: Promise<Source>;
   resolvedSource?: Source;
 };
@@ -1451,7 +1450,11 @@ export class Thread implements IVariableStoreLocationProvider {
         resolvedSourceMapUrl,
         inlineSourceOffset,
         runtimeScriptOffset,
-        event.hash,
+        // only include the script hash if content validation is enabled, and if
+        // the source does not have a redirected URL. In the latter case the
+        // original file won't have a `# sourceURL=...` comment, so the hash
+        // never matches: https://github.com/microsoft/vscode-js-debug/issues/1476
+        !event.hasSourceURL && this.launchConfig.enableContentValidation ? event.hash : undefined,
       );
 
       // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
@@ -1472,7 +1475,6 @@ export class Thread implements IVariableStoreLocationProvider {
       url: event.url,
       scriptId: event.scriptId,
       source: createSource(),
-      hash: event.hash,
     };
     script.source.then(s => (script.resolvedSource = s));