Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command customization templates #1649

Merged
merged 24 commits into from
Feb 26, 2020
Merged

Add command customization templates #1649

merged 24 commits into from
Feb 26, 2020

Conversation

bwateratmsft
Copy link
Contributor

@bwateratmsft bwateratmsft commented Feb 24, 2020

Resolves #1596, maybe also #1496. This adds fairly unlimited command customization capabilities for the commands that need it most:

  • Docker build
  • Docker run
  • Docker run (interactive)
  • Attach
  • View logs
  • Compose up
  • Compose down

@bwateratmsft bwateratmsft requested a review from a team as a code owner February 24, 2020 19:46
@bwateratmsft bwateratmsft added this to the 0.11.0 milestone Feb 24, 2020
@bwateratmsft
Copy link
Contributor Author

The changes aren't fully tested, but since there's a fair bit I wanted to get eyes on them as early as possible.

package.json Outdated Show resolved Hide resolved
@bwateratmsft bwateratmsft merged commit 053a2e3 into master Feb 26, 2020
@bwateratmsft bwateratmsft deleted the bmw/commandTemplates branch February 26, 2020 20:10
Dmarch28 pushed a commit to Dmarch28/vscode-docker that referenced this pull request Mar 4, 2021
* Add settings for command templates
@FelipeMartini
Copy link

how use this? where i configure these commands options?

@karolz-ms
Copy link
Contributor

@FelipeMartini https://code.visualstudio.com/docs/containers/reference#_command-customization

@FelipeMartini
Copy link

@FelipeMartini https://code.visualstudio.com/docs/containers/reference#_command-customization

thanks brow, i got this working for build and for logs command, also is possible to add another command like start and stop? or only these are configurable, build, logs, attach... but stop and start i not see if its possible too, do you know that @karolz-ms ???

@karolz-ms
Copy link
Contributor

thanks brow, i got this working for build and for logs command, also is possible to add another command like start and stop? or only these are configurable, build, logs, attach... but stop and start i not see if its possible too, do you know that @karolz-ms ???

Only those commands that are documented are customizable through templates, sorry. What I do for the others, if necessary, is to create a VS Code custom task https://code.visualstudio.com/docs/editor/tasks#_custom-tasks Together with a keyboard shortcut for workbench.actions.tasks.runTask (I use alt+t) that works quite well.

Also note that Docker extensions adds special tasks for Docker build, Docker run, and Docker Compose, it is all described in https://code.visualstudio.com/docs/containers/reference

@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker Command Customization
4 participants