-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jsoncons] Update to v0.137.0 #8890
Conversation
I don't understand why the Linux and windows checks are now failing with "Artifact raw xml results not found for build 17940. Please ensure you have published artifacts in any previous phases of the current build." I am creating a pull request exactly as before, but only now am seeing this message. Has something changed? |
@danielaparker, thanks for the PR! This failures due to our CI system offline for maintenance, I will help to rerun this PR after the CI system back online. See #8949 |
@danielaparker, I reopened this PR, currently CI system back online, is there any specific reasons to close this PR? |
No, that PR is fine.
Thanks,Daniel
On Monday, November 18, 2019, 10:02:27 p.m. EST, Phoebe <notifications@github.com> wrote:
@danielaparker, I reopened this PR, currently CI system back online, is there any specific reasons to close this PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@@ -3,8 +3,8 @@ include(vcpkg_common_functions) | |||
vcpkg_from_github( | |||
OUT_SOURCE_PATH SOURCE_PATH | |||
REPO danielaparker/jsoncons | |||
REF v0.136.1 | |||
SHA512 8f7c2ce8f2bdc08239b365625232ab2e9603d91374f83409606650661eb0b5dc9a685c210b07892dd402a08609c088de3c960f2900e418fe4c5f7ebb9735dded | |||
REF v0.137.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielaparker, could you update 'REF v0.137.0' to REF 0042000b250d4efe00a44c3ed5ce3f7625821538 #v0.137.0', we recommend to use commit id instead since it's more stable.
Thanks for the feedback, I'll update and open another request
On Wednesday, November 20, 2019, 02:46:52 a.m. EST, Phoebe <notifications@github.com> wrote:
@PhoebeHui commented on this pull request.
In ports/jsoncons/portfile.cmake:
@@ -3,8 +3,8 @@ include(vcpkg_common_functions)
vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO danielaparker/jsoncons
- REF v0.136.1
- SHA512 8f7c2ce8f2bdc08239b365625232ab2e9603d91374f83409606650661eb0b5dc9a685c210b07892dd402a08609c088de3c960f2900e418fe4c5f7ebb9735dded
+ REF v0.137.0
@danielaparker, could you update 'REF v0.137.0' to REF 0042000b250d4efe00a44c3ed5ce3f7625821538 #v0.137.0', we recommend to use commit id instead since it's more stable.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@danielaparker, thanks! Duplicated to #9058. |
Update jsoncons to v0.137.0