Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsoncons] Update to v0.137.0 #8890

Closed
wants to merge 1 commit into from
Closed

[jsoncons] Update to v0.137.0 #8890

wants to merge 1 commit into from

Conversation

danielaparker
Copy link
Contributor

Update jsoncons to v0.137.0

@danielaparker
Copy link
Contributor Author

I don't understand why the Linux and windows checks are now failing with

"Artifact raw xml results not found for build 17940. Please ensure you have published artifacts in any previous phases of the current build."

I am creating a pull request exactly as before, but only now am seeing this message. Has something changed?

@PhoebeHui PhoebeHui self-requested a review November 12, 2019 07:07
@PhoebeHui
Copy link
Contributor

PhoebeHui commented Nov 12, 2019

@danielaparker, thanks for the PR!

This failures due to our CI system offline for maintenance, I will help to rerun this PR after the CI system back online.

See #8949

@PhoebeHui PhoebeHui reopened this Nov 19, 2019
@PhoebeHui
Copy link
Contributor

@danielaparker, I reopened this PR, currently CI system back online, is there any specific reasons to close this PR?

@danielaparker
Copy link
Contributor Author

danielaparker commented Nov 19, 2019 via email

@grdowns grdowns changed the title [jsoncons] Update jsoncons to v0.137.0 [jsoncons] Update to v0.137.0 Nov 19, 2019
@@ -3,8 +3,8 @@ include(vcpkg_common_functions)
vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO danielaparker/jsoncons
REF v0.136.1
SHA512 8f7c2ce8f2bdc08239b365625232ab2e9603d91374f83409606650661eb0b5dc9a685c210b07892dd402a08609c088de3c960f2900e418fe4c5f7ebb9735dded
REF v0.137.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielaparker, could you update 'REF v0.137.0' to REF 0042000b250d4efe00a44c3ed5ce3f7625821538 #v0.137.0', we recommend to use commit id instead since it's more stable.

@danielaparker
Copy link
Contributor Author

danielaparker commented Nov 20, 2019 via email

@PhoebeHui
Copy link
Contributor

@danielaparker, thanks! Duplicated to #9058.

@PhoebeHui PhoebeHui closed this Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants