[Openxr-loader] Fix fatal error C1189 #7376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you let us know over "upstream" over on https://github.com/KhronosGroup/OpenXR-SDK-Source ? It's supposed to only use C++11 (we've avoided even make_unique, the horrors), so if enabling C++17 is a fix to something, it's probably our bug too? |
|
Looks like this port could be installed successfully without my patch now, I think it should have something to do with the port update five days ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Openxr-loader compile filed with a fatal error C1189 in an internal version of VS, this issue could be fixed by adding the compile option /std:c++17.