[vcpkg] Environment Variable Passthrough #7290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicroms
reviewed
Jul 17, 2019
toolsrc/src/vcpkg/build.cpp
Outdated
| if (feature == "core") | ||
| return Util::fmap_flatten(feature_list, | ||
| [&](std::string const& feature) -> std::vector<Features> { | ||
| if (feature == "core") |
There was a problem hiding this comment.
Yeah, I noticed that in the next PR.
vicroms
reviewed
Jul 17, 2019
toolsrc/src/vcpkg/build.cpp
Outdated
| const std::string& abi_tag, | ||
| const BuildPackageConfig& config) | ||
| static std::vector<System::CMakeVariable> get_cmake_vars(const VcpkgPaths& paths, | ||
| const PreBuildInfo& pre_build_info, |
There was a problem hiding this comment.
pre_build_info is not used in the function
There was a problem hiding this comment.
Ah true, but it will be 😄, I'll get rid of it for this PR.
vicroms
reviewed
Jul 17, 2019
|
No I don't think it's necessary, the two can live together. |
Rastaban
approved these changes
Jul 18, 2019
Closed
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
* use additional env param * remove partials * remove change to linux triplet * Fix some issues that vicroms pointed out * whitespace change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on Windows the only environment variables available to the portfile are those found on a whitelist hard-coded into vcpkg. This change allows us to set the variables passed through as a Cmake list in the triplet.
A change should be made to vcpkg to sanitize the linux environment.