Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallel file operations #7228

Merged
merged 18 commits into from
Jul 24, 2019
Merged

Parallel file operations #7228

merged 18 commits into from
Jul 24, 2019

Conversation

strega-nil
Copy link
Contributor

@strega-nil strega-nil commented Jul 10, 2019 •
edited
Loading

  • change over to using our own implementation of symlink_status and is_symlink on windows, since the originals (in std::experimental::filesystem, anyways) are broken
  • generic parallel work queue implementation
  • delete files in parallel
  • copy files in parallel? -- future PR
  • download files in parallel? -- future PR

@JackBoosY
Copy link
Contributor

It seems to be related to #6989.

@ras0219-msft ras0219-msft added the info:internal This PR or Issue was filed by the vcpkg team. label Jul 11, 2019
@strega-nil strega-nil marked this pull request as ready for review July 12, 2019 01:17
cbezault
cbezault approved these changes Jul 17, 2019
View reviewed changes
toolsrc/src/tests.files.cpp Outdated Show resolved Hide resolved
@grdowns grdowns self-assigned this Jul 19, 2019
grdowns
grdowns reviewed Jul 19, 2019
View reviewed changes
toolsrc/include/vcpkg/base/work_queue.h Outdated Show resolved Hide resolved
toolsrc/src/vcpkg/build.cpp Outdated Show resolved Hide resolved
toolsrc/src/vcpkg-tests/files.cpp Outdated Show resolved Hide resolved
@strega-nil strega-nil merged commit 36dea3d into microsoft:master Jul 24, 2019
@strega-nil strega-nil deleted the parallel-file-ops branch July 24, 2019 18:15
@mitza-oci mitza-oci mentioned this pull request Jul 24, 2019
Closed
@mitza-oci
Copy link
Contributor

Please see #7405 -- this broke compiling vcpkg using VS2015

@strega-nil strega-nil mentioned this pull request Aug 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grdowns grdowns grdowns left review comments

@cbezault cbezault cbezault approved these changes

@ras0219-msft ras0219-msft Awaiting requested review from ras0219-msft

Assignees

@strega-nil strega-nil

@ras0219-msft ras0219-msft

@grdowns grdowns

Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@strega-nil @JackBoosY @mitza-oci @cbezault @grdowns @ras0219-msft