Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xmsh]Upgrade version to 0.5.2 and fix build failure. #7155

Merged
merged 3 commits into from
Jan 9, 2020
Merged

[xmsh]Upgrade version to 0.5.2 and fix build failure. #7155

merged 3 commits into from
Jan 9, 2020

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Jul 4, 2019 •
edited
Loading

Upgrade version to 0.5.2.
NOTE: Xmsh needs to use gcc with version greater than 7.1 under linux.

Related: #6618.

Note: this port doesn't contain any feature.

@JackBoosY JackBoosY added the info:internal This PR or Issue was filed by the vcpkg team. label Jul 4, 2019
@JackBoosY JackBoosY mentioned this pull request Jul 4, 2019
Closed
@JackBoosY JackBoosY marked this pull request as ready for review July 4, 2019 10:06
@JackBoosY
Copy link
Contributor Author

JackBoosY commented Jul 9, 2019 •
edited
Loading

PR-EAGER reports errors because the gcc version of the CI system does not match.

@JackBoosY JackBoosY mentioned this pull request Jul 16, 2019
Merged
@JackBoosY
Copy link
Contributor Author

JackBoosY commented Jul 16, 2019 •
edited
Loading

The source needs to do different processing for clang/linux for experimental/filesystem.

Related issue: #260 #52.

@Rastaban I don't have OSX VM, can you help me to solve this issue?

@PhoebeHui
Copy link
Contributor

Related to #7217

@Rastaban
Copy link
Contributor

Rastaban commented Jul 17, 2019 •
edited
Loading

xcode 11 will ship with <filesystem>. Rather than adding in special logic to get this library to build we should wait for xcode 11 to ship and then update.

https://developer.apple.com/documentation/xcode_release_notes

@Rastaban
Copy link
Contributor

It looks like xcode 11 is now out. @cbezault would you be able to update our Mac CI machines?

@Rastaban Rastaban assigned dan-shaw and unassigned Rastaban Oct 3, 2019
@PhoebeHui PhoebeHui mentioned this pull request Nov 7, 2019
Closed
@vicroms
Copy link
Member

vicroms commented Nov 7, 2019

/azp run

2 similar comments
@JackBoosY
Copy link
Contributor Author

/azp run

@JackBoosY
Copy link
Contributor Author

/azp run

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Dec 3, 2019
@dan-shaw
Copy link
Contributor

LGTM, waiting for mac CI

@ras0219-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 7155 in repo microsoft/vcpkg

@dan-shaw dan-shaw merged commit dad1833 into microsoft:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbezault cbezault cbezault approved these changes

@PhoebeHui PhoebeHui PhoebeHui approved these changes

@dan-shaw dan-shaw dan-shaw approved these changes

Assignees

@dan-shaw dan-shaw

Labels
info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JackBoosY @PhoebeHui @Rastaban @vicroms @dan-shaw @ras0219-msft @cbezault