Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenMPI] add a new port #7142

Merged
merged 7 commits into from
Jul 31, 2019
Merged

[OpenMPI] add a new port #7142

merged 7 commits into from
Jul 31, 2019

Conversation

cenit
Copy link
Contributor

@cenit cenit commented Jul 3, 2019

No description provided.

@cenit cenit marked this pull request as ready for review July 3, 2019 11:09
@cenit
Copy link
Contributor Author

cenit commented Jul 3, 2019

i also provided a generic mpi port, which is the one that should be used. It redirects to msmpi on windows, openmpi otherwise.
Still untested, but it should be ready

@cenit
Copy link
Contributor Author

cenit commented Jul 5, 2019

there are failures on Windows but I think they are perfectly acceptable, since openmpi is ported only for linux/mac

@vicroms
Copy link
Member

vicroms commented Jul 15, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vicroms
Copy link
Member

vicroms commented Jul 18, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vicroms
Copy link
Member

vicroms commented Jul 18, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vicroms
Copy link
Member

vicroms commented Jul 19, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vicroms
Copy link
Member

vicroms commented Jul 19, 2019

Sorry for the barrage of /azp run, this PR exposed some flaky ports that weren't fixed yet.

@cenit
Copy link
Contributor Author

cenit commented Jul 19, 2019

Sure! I have a special talent for exposing this kind of problems :D
Please let me know if I can help in any way

@vicroms
Copy link
Member

vicroms commented Jul 22, 2019

Is there a reason why UWP support has been disabled?

There's a regression on msmpi:x64-uwp, and I'm also able to build it locally.

@cenit
Copy link
Contributor Author

cenit commented Jul 22, 2019

msmpi is not built from source (unfortunately - microsoft/Microsoft-MPI#2), so I just assumed the library was not uwp-ready (the same .lib is used for x64-windows...)
Unfortunately I don't have any program to test msmpi:x64-uwp, if you have any please let me know if I overlooked it. My principle was "better safe than sorry", and so I removed the compatibility if it was not really there.

@vicroms
Copy link
Member

vicroms commented Jul 31, 2019

Thanks for the PR!

@vicroms vicroms merged commit 455223d into microsoft:master Jul 31, 2019
@cenit cenit deleted the dev/cenit/mpi branch July 31, 2019 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants