Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg] Use spaces instead of semicolons in the output #7080

Merged
merged 3 commits into from
Jul 1, 2019
Merged

[vcpkg] Use spaces instead of semicolons in the output #7080

merged 3 commits into from
Jul 1, 2019

Conversation

Pospelove
Copy link
Contributor

If the package build fails, we get an error message like this:

-- Building x86-windows-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:134 (message):
    Command failed: C:/vcpkg/downloads/tools/cmake-3.14.0-windows/cmake-3.14.0-win32-x86/bin/cmake.exe;--build;.;--config;Debug;--;/p:VCPkgLocalAppDataDisabled=true;/p:UseIntelMKL=No;/m

For readability, it would be better to use spaces instead of semicolons to separate command arguments.

-- Building x86-windows-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:135 (message):
    Command failed: C:/vcpkg/downloads/tools/cmake-3.14.0-windows/cmake-3.14.0-win32-x86/bin/cmake.exe --build . --config Debug -- /p:VCPkgLocalAppDataDisabled=true /p:UseIntelMKL=No /m

@cskrisz
Copy link
Contributor

cskrisz commented Jun 28, 2019

  • Command arguments containing spaces should be wrapped in quotes, so we know that they are in fact, a single argument
  • vcpkg_execute_required_process and vcpkg_execute_required_process_repeat should also use this format then

@Pospelove Pospelove changed the title Use spaces instead of semicolons in the output [vcpkg] Use spaces instead of semicolons in the output Jun 28, 2019
@Pospelove
Copy link
Contributor Author

@cskrisz Thanks for your feedback. Please review again.

scripts/ports.cmake Outdated Show resolved Hide resolved
@vicroms
Copy link
Member

vicroms commented Jul 1, 2019

Thanks for the PR!

@vicroms vicroms merged commit b26cb1a into microsoft:master Jul 1, 2019
@MVoz
Copy link
Contributor

MVoz commented Jul 2, 2019

@vicroms

meson error

vcpkg_install_meson.cmake

COMMAND ${NINJA} install -v

failed
vcpkg_execute_required_process(

ok
execute_process(

old version, now I recheck

@MVoz
Copy link
Contributor

MVoz commented Jul 2, 2019

false alarm
can't figure out why python gives an error


"cp" "-f" "../src/tk-doc-zip-b6950d3b86/gtkdoc/__init__.py" "../src/tk-doc-zip-b6950d3b86/gtkdoc/check.py" "../src/tk-doc-zip-b6950d3b86/gtkdoc/common.py" "../src/tk-doc-zip-b6950d3b86/gtkdoc/fixxref.py" "../src/tk-doc-zip-b6950d3b86/gtkdoc/highlight.py" "../src/tk-doc-zip-b6950d3b86/gtkdoc/md_to_db.py" "../src/tk-doc-zip-b6950d3b86/gtkdoc/mkdb.py" "../src/tk-doc-zip-b6950d3b86/gtkdoc/mkhtml.py" "../src/tk-doc-zip-b6950d3b86/gtkdoc/mkhtml2.py" "../src/tk-doc-zip-b6950d3b86/gtkdoc/mkman.py" "../src/tk-doc-zip-b6950d3b86/gtkdoc/mkpdf.py" "../src/tk-doc-zip-b6950d3b86/gtkdoc/rebase.py" "../src/tk-doc-zip-b6950d3b86/gtkdoc/scan.py" "../src/tk-doc-zip-b6950d3b86/gtkdoc/scangobj.py" "gtkdoc"
CreateProcess failed: The system cannot find the file specified.
ninja: build stopped: subcommand failed.

Apparently in this, the CP team
"cp" "-f"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants