Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python3 tool on Windows #7051

Merged
merged 3 commits into from
Jul 2, 2019

Conversation

cskrisz
Copy link
Contributor

@cskrisz cskrisz commented Jun 26, 2019

Remove the file python37._pth from the python3 tool folder to allow scripts to import any modules.

Closes: #6988, #6979, #6984, #7066

@ZeroAurora
Copy link

If python is already installed by vcpkg before, after this PR is merged, should users remove python37._pth manually?

@cskrisz
Copy link
Contributor Author

cskrisz commented Jun 30, 2019

I didn't realize vcpkg is already trying to stay backward compatible with old installations. For example, some portable tools won't even get updated if they have already been installed.

@ZeroAurora
Copy link

So should a warning be set? Or a function to delete python37._pth?

@cskrisz
Copy link
Contributor Author

cskrisz commented Jun 30, 2019

No, the underlying problem regarding the update process of tools should be addressed. That's not necessarily complicated, every tool ${SUBDIR} should contain a version number and for cases like this, we could append a revision number.

@cskrisz
Copy link
Contributor Author

cskrisz commented Jun 30, 2019

I made the changes for python3 and added the version to SUBDIR as I see some other tools have already done this.

@vicroms
Copy link
Member

vicroms commented Jul 2, 2019

@cskrisz

Thanks for the PR!

I tested all ports using PYTHON3 in PR #7133.
Only open62541 needed some fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ports fail on Windows since Python update
3 participants