[openxr-loader] Initial port #6339
Conversation
|
Hi @jherico, thanks for your new port. I see the test results from the current CI system that the port failed on all triplets. Please refer to the following attachment. |
|
Whoops... looks like there's a build-time python3 dependency I didn't notice since I already have Python3 installed locally. |
|
@jherico, I checked the test results again from the current CI system after you added the python3 dependency commit. The port failed on all triplets. Please take a look at the failure log. |
|
Thanks. Some of the errors seem to be originating from this error inside
Investigation suggests that this is an error that only occurs on Python versions less than 3.6. I'll investigate to see what vcpkg fetches when a python build-time dependency is declared. The linux build on the other hand is failing because of this:
I encountered this when I was doing my docker build, which is why I had to add it in the config, but on examining some of the other ports I'm guessing pkg-config isn't a part of the CI build environment for linux based triplets. I'll investigate further for solutions. thanks for the feedback. |
|
It looks like it uses Python 3.5.4 on windows see vcpkg_find_acquire_program. Maybe it is time to update to the latest version. |
|
Updating Python3 in #6383 |
|
I tried applying this change locallly and the build still failed. The build system includes it's own python modules which need to be found by the python scripts and it's using the However, the embedded python version used by vcpkg explicitly ignores |
jherico
force-pushed
the
openxr
branch
2 times, most recently
from
a5b0fab
to
50b80ea
Compare
|
OK, I've added two patch files. The first modifies the executed python scripts to explicitly add the required library paths to The second modifies the |
|
New test results from current CI system:
|
jherico
force-pushed
the
openxr
branch
2 times, most recently
from
d5efb06
to
1e4bc4a
Compare
|
The failures are still all caused by the embedded python being less than 3.6. However, I've added a patch file that should hopefully resolve this pending #6383 |
|
The name "openxr" seems a bit too broad. Would "openxr-loader" be more appropriate? |
|
@brycehutchings agreed, renamed. |
jherico
force-pushed
the
openxr
branch
2 times, most recently
from
35e7527
to
7d5c9f9
Compare
|
/azp run |
|
The port fails to build on ARM and UWP, I suppose these failures were expected (am I right?) and I've added some explicit failure messages. If not, I'm OK with merging this PR as an initial version and patching support for the remaining platforms in a different pull request. |
|
Sounds good
…On Tue, Jul 9, 2019 at 3:46 PM Victor Romero ***@***.***> wrote:
@jherico <https://github.com/jherico>
The port fails to build on ARM and UWP, I suppose these failures were
expected (am I right?) and I've added some explicit failure messages. If
not, I'm OK with merging this PR as an initial version and patching support
for the remaining platforms in a different pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6339?email_source=notifications&email_token=AALWNSRNR7BHA4OCRVV33LLP6UILRA5CNFSM4HLNQTJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZRYEBA#issuecomment-509837828>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AALWNSTDUQSMKHWEGGXB2ILP6UILRANCNFSM4HLNQTJA>
.
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks for the PR! |
A Khronos released SDK, the OpenXR loader is similar in function to the Vulkan loader, but currently is designed to be client built rather than installed like the Vulkan SDK. This PR adds support in vcpkg.