Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Fix CMAKE_SYSTEM_PROCESSOR (Resubmission of #4688) #5697

Closed
wants to merge 15 commits into from

Conversation

vicroms
Copy link
Member

@vicroms vicroms commented Mar 15, 2019

Related PRs:
#4970
#4688
#5218

#4688 was reverted due to regressions

Quoting @UnaNancyOwen:

In case of UWP and Linux triplets, CMAKE_SYSTEM_PROCESSOR is not specified. It is empty.
For details this problems, Please refer to this comment #4635 (comment).
This pull request will set CMAKE_SYSTEM_PROCESSOR under UWP and Linux triplets.
If you want to explicitly specified CPU arcitecture, You can use VCPKG_CMAKE_SYSTEM_PROCESSOR in triplet files.

UnaNancyOwen and others added 5 commits November 10, 2018 12:57
Add CMAKE_SYSTEM_PROCESSOR setting under UWP, Linux, and Darwin.
If explicitly specified VCPKG_CMAKE_SYSTEM_PROCESSOR in triplet files, CMAKE_SYSTEM_PROCESSOR is set to specified architecture.
@vicroms vicroms mentioned this pull request Mar 16, 2019
@vicroms vicroms self-assigned this Mar 16, 2019
@vicroms vicroms added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed wip info:internal This PR or Issue was filed by the vcpkg team. labels Mar 16, 2019
@vicroms vicroms changed the title Fix CMAKE_SYSTEM_PROCESSOR (Resubmission of #4688) [wip] Fix CMAKE_SYSTEM_PROCESSOR (Resubmission of #4688) Mar 16, 2019
@vicroms vicroms removed the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Mar 16, 2019
@vicroms
Copy link
Member Author

vicroms commented Mar 19, 2019

Current Regressions Status

Port Regressions
anax x86-windows
caffe2 x64-linux
darknet x64-windows + x64-windows-static + x86-windows
ffmpeg x64-windows + x64-uwp
icu x64-windows
libvpx x64-windows + x64-uwp
glew x64-windows-static
netcdf-c x64-windows-static
octomap x64-windows + x86-windows
openssl-uwp x64-uwp + arm-uwp
openssl-windows x64-windows + x64-windows-static + x86-windows
tbb x64-windows + x64-windows-static + x86-windows
x264 x64-windows + x64-uwp
vxl x64-linux
z3 x64-linux

ffmpeg, icu, libvpx, and x264: failed acquiring msys pacman packages.
openssl-windows, tbb: Fails vcpkg_test_cmake(), test CMake function has bug on 64-bits, need to check logs for exact error message. Should be fixed in master
vxl: Requires built-in OpenJpeg which was already installed in full rebuild. (Rerun with --exclude openjpeg)

@cenit
Copy link
Contributor

cenit commented Mar 19, 2019

For darknet static I can open a PR. It is just a matter of a bug in the findpthreads_windows.cmake which is fixed in a PR upstream ( we are still testing it) and which I can submit also here. It should not have passed CI tests for static from the beginning...

@cenit
Copy link
Contributor

cenit commented Mar 19, 2019

also many of those ports are fixed in my #5169 PR, if you don't want to duplicate efforts

@vicroms
Copy link
Member Author

vicroms commented Mar 19, 2019

@cenit
Ok! Let's work on getting #5169 merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants