Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kd-soap] update to 2.2.0 and rename to kdsoap #36101

Merged
merged 2 commits into from
Jan 11, 2024
Merged

[kd-soap] update to 2.2.0 and rename to kdsoap #36101

merged 2 commits into from
Jan 11, 2024

Conversation

JonLiu1993
Copy link
Member

@JonLiu1993 JonLiu1993 commented Jan 10, 2024 •
edited
Loading

Fixes #36092

  • Update kd-soap to the latest version 2.2.0
  • According to the request of the port author rename "kd-soap" to "kdsoap' @winterz

I checked that our other ports do not depend on kd-soap, so I think it can be renamed.

Tested usage successfully by kdsoap:x64-windows:

kdsoap provides CMake targets:

  # this is heuristically generated, and may not be correct
  find_package(KDSoap-qt6 CONFIG REQUIRED)
  target_link_libraries(main PRIVATE KDSoap::kdsoap KDSoap::kdsoap-server)
  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@JonLiu1993 JonLiu1993 added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Jan 10, 2024
JonLiu1993
JonLiu1993 commented Jan 10, 2024
View reviewed changes
ports/kdsoap/portfile.cmake
)

vcpkg_extract_source_archive(
SOURCE_PATH
ARCHIVE "${ARCHIVE}"
PATCHES
Ensure-KDSoapConfig-finds-Qt-first.patch
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch is applied in the latest version.

@JonLiu1993 JonLiu1993 marked this pull request as ready for review January 10, 2024 06:57
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Jan 10, 2024
@dg0yt
Copy link
Contributor

dg0yt commented Jan 10, 2024

I checked that our other ports do not depend on kd-soap, so I think it can be renamed.

You can always update vcpkg ports, but you cannot know about your users' dependencies.

@JavierMatosD
Copy link
Contributor

I think we are the only one using kd-soap so I think this rename is appropriate. https://repology.org/project/kdsoap/versions

@JavierMatosD JavierMatosD merged commit 6901e71 into microsoft:master Jan 11, 2024
15 checks passed
@JonLiu1993 JonLiu1993 deleted the dev/Jon/kdsoap branch January 15, 2024 02:34
Osyotr pushed a commit to Osyotr/vcpkg that referenced this pull request Jan 23, 2024
@JonLiu1993 @Osyotr
[kd-soap] update to 2.2.0 and rename to kdsoap (microsoft#36101)
f775ae6 
* kd-soap update to 2.2.0

* update version

---------

Co-authored-by: vzhli17 <v-zhli17@microsoft.com>
TomKatom pushed a commit to TomKatom/vcpkg that referenced this pull request Feb 23, 2024
@JonLiu1993 @TomKatom
[kd-soap] update to 2.2.0 and rename to kdsoap (microsoft#36101)
bb267a0 
* kd-soap update to 2.2.0

* update version

---------

Co-authored-by: vzhli17 <v-zhli17@microsoft.com>
@WangWeiLin-MV WangWeiLin-MV mentioned this pull request Mar 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonicaLiu0311 MonicaLiu0311 MonicaLiu0311 approved these changes

Assignees

@MonicaLiu0311 MonicaLiu0311

Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kd-soap update to 2.2.0
4 participants
@JonLiu1993 @dg0yt @JavierMatosD @MonicaLiu0311