-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[plplot] Fix download errors #34441
[plplot] Fix download errors #34441
Conversation
This looks like a tooling bug. Did you manage to repro it originally? |
I managed to repro on macOS |
The handling of space in URLs was intentionally changed in vcpkg tool some months ago. |
I checked and we are just passing this down to curl as a quoted argument so this seems to be a problem with specifically macos' copy of curl. |
Do you remember the change you mean here? The intent seems to be that we do the %20 for you but we expected curl to do it. (and curl does do it on Windows... which makes me wonder if we are passing parameters incorrectly...) |
I stand corrected; the reason it works on Windows is that there |
Alternate resolution of microsoft/vcpkg#34441 The URL is supposed to contain query parameters and similar, so we can't go all the way to full urlencode(). But spaces should do the same thing with curl as they do for WinHTTP and get encoded correctly.
I'm going to merge this as-is: I think we should fix it in the tool, but as written fixes it until we do the tool release, and it doesn't harm anything. |
I failed to find the change which I believed to remember. |
Alternate resolution of microsoft/vcpkg#34441 The URL is supposed to contain query parameters and similar, so we can't go all the way to full urlencode(). But spaces should do the same thing with curl as they do for WinHTTP and get encoded correctly.
Fixes #34357
Fix download
url
error.SHA512s are updated for each updated downloadThe "supports" clause reflects platforms that may be fixed by this new versionAny fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --all
and committing the result.Compile test pass with following triplets: