Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plplot] Fix download errors #34441

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Conversation

jimwang118
Copy link
Contributor

@jimwang118 jimwang118 commented Oct 12, 2023

Fixes #34357

error: https://sourceforge.net/projects/plplot/files/plplot/5.15.0 Source/plplot-5.15.0.tar.gz/download?use_mirror=tenet: curl failed to download with exit code 3
curl: (3) URL rejected: Malformed input to a URL function

Fix download url error.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Compile test pass with following triplets:

x64-osx

@jimwang118 jimwang118 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Oct 12, 2023
@jimwang118 jimwang118 marked this pull request as ready for review October 12, 2023 09:34
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Oct 12, 2023
@BillyONeal
Copy link
Member

This looks like a tooling bug. Did you manage to repro it originally?

@BillyONeal
Copy link
Member

I managed to repro on macOS

@dg0yt
Copy link
Contributor

dg0yt commented Oct 12, 2023

The handling of space in URLs was intentionally changed in vcpkg tool some months ago.

@BillyONeal
Copy link
Member

The handling of space in URLs was intentionally changed in vcpkg tool some months ago.

I checked and we are just passing this down to curl as a quoted argument so this seems to be a problem with specifically macos' copy of curl.

@BillyONeal
Copy link
Member

The handling of space in URLs was intentionally changed in vcpkg tool some months ago.

Do you remember the change you mean here? The intent seems to be that we do the %20 for you but we expected curl to do it. (and curl does do it on Windows... which makes me wonder if we are passing parameters incorrectly...)

@BillyONeal
Copy link
Member

I stand corrected; the reason it works on Windows is that there x-download is using WinHTTP.

BillyONeal added a commit to BillyONeal/vcpkg-tool that referenced this pull request Oct 13, 2023
Alternate resolution of microsoft/vcpkg#34441

The URL is supposed to contain query parameters and similar, so we can't go all the way to full urlencode(). But spaces should do the same thing with curl as they do for WinHTTP and get encoded correctly.
@BillyONeal
Copy link
Member

I'm going to merge this as-is: I think we should fix it in the tool, but as written fixes it until we do the tool release, and it doesn't harm anything.

@BillyONeal BillyONeal merged commit b2f2cd3 into microsoft:master Oct 13, 2023
15 checks passed
@jimwang118 jimwang118 deleted the fixplplot branch October 13, 2023 03:01
@dg0yt
Copy link
Contributor

dg0yt commented Oct 13, 2023

Do you remember the change you mean here? The intent seems to be that we do the %20 for you but we expected curl to do it. (and curl does do it on Windows... which makes me wonder if we are passing parameters incorrectly...)

I failed to find the change which I believed to remember.
I found a curl change in 7.78.0: curl/curl#7073.

clementperon pushed a commit to clementperon/vcpkg that referenced this pull request Oct 16, 2023
BillyONeal added a commit to microsoft/vcpkg-tool that referenced this pull request Oct 17, 2023
Alternate resolution of microsoft/vcpkg#34441

The URL is supposed to contain query parameters and similar, so we can't go all the way to full urlencode(). But spaces should do the same thing with curl as they do for WinHTTP and get encoded correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plplot build failure
4 participants